Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 4 extra featured projects to explore page (closes #971) #993

Merged
merged 17 commits into from
Mar 6, 2024

Conversation

SouravInsights
Copy link
Contributor

@SouravInsights SouravInsights commented Feb 21, 2024

Description:

Added accountIds of 4 extra projects (nice-node, startkenet.js, snapshot & svelte-stepper) to the mainnet array of FEATURED_PROJECT_ACCOUNT_IDS.

Screenshots:

CleanShot 2024-02-22 at 04 48 32@2x

Note:

I'm not sure about the criteria to select featured projects, but as far as I understand, the consensus is to strike a balance between showcasing well-known projects and giving visibility to lesser-known projects that might deserve attention. Choosing popular projects potentially increase engagement within the platform while promoting newer or less recognized projects, foster diversity & encourage community growth.

But currently, I have added Nice Node, Snapshot & Starknet.js and all 3 projects are well known so let me know if I need to include any other projects to the list. From a quick glance, I think ens-normalize.js is a cool one! Haven't explored all other projects as of now... Let me know your thoughts! @brandonhaslegs @efstajas

closes #971

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for drips-app-v2 ready!

Name Link
🔨 Latest commit 83d1a35
🔍 Latest deploy log https://app.netlify.com/sites/drips-app-v2/deploys/65e8387190d9360008aab683
😎 Deploy Preview https://deploy-preview-993--drips-app-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonhaslegs
Copy link
Collaborator

Hey thanks! Someone will take a look today. Can you mention which issue this closes so that it'll close the issue when the PR is merged?

@SouravInsights
Copy link
Contributor Author

SouravInsights commented Feb 22, 2024

Hey thanks! Someone will take a look today. Can you mention which issue this closes so that it'll close the issue when the PR is merged?

Sure! This is the issue: #971 closes #971

@brandonhaslegs
Copy link
Collaborator

Sorry btw I meant something like this:

closes #971

@SouravInsights
Copy link
Contributor Author

Sorry btw I meant something like this:

closes #971

oh right right.. sorry!!

@efstajas
Copy link
Contributor

thanks a lot! nice selection already.

Let's maybe replace my project svelte-stepper with https://drips.network/app/projects/github/graphprotocol/graph-node, otherwise LGTM.

@evvvritt
Copy link
Collaborator

thanks! can you please put closes #971 in the title of this PR so when we squash and merge it will auto-close the issue?

@brandonhaslegs
Copy link
Collaborator

thanks! can you please put closes #971 in the title of this PR so when we squash and merge it will auto-close the issue?

I think it still works as a comment right? We talked about that further up there 👆

Copy link
Contributor

@jo-elimu jo-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evvvritt
Copy link
Collaborator

No I think it needs to be in the title to auto-close (since title is used as the commit message which triggers the auto-close) @brandonhaslegs

@evvvritt evvvritt changed the title add 4 extra featured projects to explore page add 4 extra featured projects to explore page (closes #971) Feb 22, 2024
@evvvritt
Copy link
Collaborator

Code correct but is stacking 8 projects on mobile too tall? @brandonhaslegs

@SouravInsights
Copy link
Contributor Author

thanks a lot! nice selection already.

Let's maybe replace my project svelte-stepper with https://drips.network/app/projects/github/graphprotocol/graph-node, otherwise LGTM.

No no, that's not what I meant! I mean we should definitely give visibility to lesser-known projects by individuals too. If all the featured projects are well known & popular then it would be not as diverse & maybe a bit misaligned. Bdw, I just checked out svelte-stepper & I think it's a cool project that deserve attention!

@SouravInsights
Copy link
Contributor Author

Code correct but is stacking 8 projects on mobile too tall? @brandonhaslegs

I can think of 2 ideas..

  • Pagination: We can split the 8 cards into smaller subsets, likes 4 cards per page and have controls to navigate between pages.

  • Carousel: We can also have an horizontal carousel that allows users to swipe left or right to view cards. Although it's still a long list to scroll through but I think users are accustomed to swiping left or right to navigate through content on mobile devices, which makes horizontal scrolling feel natural and intuitive.

@brandonhaslegs
Copy link
Collaborator

Good point. I think a horizontal overflow would be fine in mobile but need to design something. You can also suggest something directly in code if you'd like.

@efstajas
Copy link
Contributor

No I think it needs to be in the title to auto-close (since title is used as the commit message which triggers the auto-close) @brandonhaslegs

it doesn't actually, just needs to be in the initial PR description. just added it there :)

No no, that's not what I meant! I mean we should definitely give visibility to lesser-known projects by individuals too. If all the featured projects are well known & popular then it would be not as diverse & maybe a bit misaligned. Bdw, I just checked out svelte-stepper & I think it's a cool project that deserve attention!

I got that, all good! I just think graph node should be featured for sure generally (because it's a big name), and am not super sure that featuring a project by one of the core maintainers of Drips is necessarily the best look, though I really appreciate that you like it 🙌

Code correct but is stacking 8 projects on mobile too tall?

... We could also just hide everything after the first 4 projects on mobile with a media query. Maybe a bit strange to have different content depending on screen size but I think in this instance it could be OK.

@SouravInsights SouravInsights marked this pull request as ready for review February 23, 2024 00:02
@SouravInsights
Copy link
Contributor Author

I've tried something simple to showcase all the 8 featured projects for smaller screen sizes. Do let me know your feedback! @brandonhaslegs @efstajas

Recording: https://www.loom.com/share/f6be05a3fa7b40df964cdce7b3feb25f?sid=6f64f1bb-2afe-4e77-9c20-512620d4e9fd

@SouravInsights
Copy link
Contributor Author

Also, replaced svelte-stepper with graph-node

Copy link
Contributor

@jo-elimu jo-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with "Build GQL types":

[STARTED] Load GraphQL schemas
[FAILED] 
[FAILED]         Failed to load schema from https://drips-api-mainnet-s1.up.railway.app/:
[FAILED] 
[FAILED]         Context creation failed: Unauthorized
[FAILED]         GraphQLError: Context creation failed: Unauthorized

@efstajas
Copy link
Contributor

@jo-elimu The reason this happens is because PRs from forked repos cannot access the target repo's secrets. In this case, it's failing, because one of those secrets is the GQL access token.

I'm not super sure how to fix this atm. Looking into it.

@efstajas
Copy link
Contributor

efstajas commented Feb 23, 2024

Alright, the test thing has been fixed, tests should pass now 👌

@SouravInsights
Copy link
Contributor Author

Have you guys tested this? Let me know if there's any issues with merging this @efstajas @evvvritt

@brandonhaslegs
Copy link
Collaborator

Hey, so the overflow for this should be horizontal not vertical.

@SouravInsights
Copy link
Contributor Author

Hey, so the overflow for this should be horizontal not vertical.

Yeah making it vertically scrollable was intentional.. But if you think horizontal is better then I'll make the necessary changes..

@brandonhaslegs
Copy link
Collaborator

Yeah I think horizontal scroll is normal behavior, like on Instagram when you post multiple photos

@SouravInsights
Copy link
Contributor Author

Yeah I think horizontal scroll is normal behavior, like on Instagram when you post multiple photos

cool, just pushed the changes..

Copy link
Contributor

@efstajas efstajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Ideally the scrolling would snap to project cards, but we can follow up with this.

@efstajas efstajas merged commit 318f1f2 into drips-network:main Mar 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 4 extra featured projects to explore page
5 participants