-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 4 extra featured projects to explore page (closes #971) #993
Conversation
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey thanks! Someone will take a look today. Can you mention which issue this closes so that it'll close the issue when the PR is merged? |
Sorry btw I meant something like this: closes #971 |
oh right right.. sorry!! |
thanks a lot! nice selection already. Let's maybe replace my project |
thanks! can you please put |
I think it still works as a comment right? We talked about that further up there 👆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I think it needs to be in the title to auto-close (since title is used as the commit message which triggers the auto-close) @brandonhaslegs |
Co-authored-by: Jo G. <[email protected]>
Code correct but is stacking 8 projects on mobile too tall? @brandonhaslegs |
No no, that's not what I meant! I mean we should definitely give visibility to lesser-known projects by individuals too. If all the featured projects are well known & popular then it would be not as diverse & maybe a bit misaligned. Bdw, I just checked out |
I can think of 2 ideas..
|
Good point. I think a horizontal overflow would be fine in mobile but need to design something. You can also suggest something directly in code if you'd like. |
it doesn't actually, just needs to be in the initial PR description. just added it there :)
I got that, all good! I just think graph node should be featured for sure generally (because it's a big name), and am not super sure that featuring a project by one of the core maintainers of Drips is necessarily the best look, though I really appreciate that you like it 🙌
... We could also just hide everything after the first 4 projects on mobile with a media query. Maybe a bit strange to have different content depending on screen size but I think in this instance it could be OK. |
I've tried something simple to showcase all the 8 featured projects for smaller screen sizes. Do let me know your feedback! @brandonhaslegs @efstajas Recording: https://www.loom.com/share/f6be05a3fa7b40df964cdce7b3feb25f?sid=6f64f1bb-2afe-4e77-9c20-512620d4e9fd |
Also, replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a problem with "Build GQL types":
[STARTED] Load GraphQL schemas
[FAILED]
[FAILED] Failed to load schema from https://drips-api-mainnet-s1.up.railway.app/:
[FAILED]
[FAILED] Context creation failed: Unauthorized
[FAILED] GraphQLError: Context creation failed: Unauthorized
@jo-elimu The reason this happens is because PRs from forked repos cannot access the target repo's secrets. In this case, it's failing, because one of those secrets is the GQL access token. I'm not super sure how to fix this atm. Looking into it. |
Alright, the test thing has been fixed, tests should pass now 👌 |
Hey, so the overflow for this should be horizontal not vertical. |
Yeah making it vertically scrollable was intentional.. But if you think horizontal is better then I'll make the necessary changes.. |
Yeah I think horizontal scroll is normal behavior, like on Instagram when you post multiple photos |
cool, just pushed the changes.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Ideally the scrolling would snap to project cards, but we can follow up with this.
Description:
Added
accountIds
of 4 extra projects (nice-node, startkenet.js, snapshot & svelte-stepper) to the mainnet array ofFEATURED_PROJECT_ACCOUNT_IDS
.Screenshots:
Note:
I'm not sure about the criteria to select featured projects, but as far as I understand, the consensus is to strike a balance between showcasing well-known projects and giving visibility to lesser-known projects that might deserve attention. Choosing popular projects potentially increase engagement within the platform while promoting newer or less recognized projects, foster diversity & encourage community growth.
But currently, I have added Nice Node, Snapshot & Starknet.js and all 3 projects are well known so let me know if I need to include any other projects to the list. From a quick glance, I think ens-normalize.js is a cool one! Haven't explored all other projects as of now... Let me know your thoughts! @brandonhaslegs @efstajas
closes #971