Add windows-latest to CI

[jo-elimu]

No description provided.

[netlify]

‼️ Deploy request for drips-app-v2 rejected.

Name	Link
🔨 Latest commit	850923f

[efstajas]

Any specific reason to run svelte-check on macos as well?

[jo-elimu]

Any specific reason to run svelte-check on macos as well?

Just to make sure the software compiles for developers using different types of operating systems. We should also add support for developers with Windows machines (windows-latest), but that will require some more code changes.

[jo-elimu]

@efstajas Getting "Container action is only supported on Linux": https://github.com/drips-network/app/actions/runs/8027003698/job/21930386799?pr=998

How do developers on Mac OS typically solve this?

[efstajas]

Windows support should be given once #997 is merged.

I don't see how running our GH actions on mac OS in addition to Ubuntu would help ensure cross-platform compatibility of our dev stack. I could see running e.g. E2E tests on Mac OS, but they're executed within a docker container anyway. svelte-check is cross-platform and should return the exact same output no matter what platform it's run on — if not, that's a bug with svelte-check, not with our project.

[jo-elimu]

Windows support should be given once #997 is merged.

@efstajas The svelte-check seems to be failing with Windows also?: https://github.com/drips-network/app/actions/runs/8064562273/job/22028695015?pr=998

Error: Container action is only supported on Linux

Is there any way we can make the Populate .env file step compatible with Windows also?

[efstajas]

When I say "windows support should be given" I meant that you can run the app locally on Windows, and npm install should no longer fail. Not talking about the GH actions.

I still don't understand the goal here — what's the benefit of running the svelte-check action on multiple different operating systems?

[efstajas]

Closing this for now until the above ☝️ is addressed