Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Romanian language support #124

Closed
wants to merge 4 commits into from

Conversation

ticlazau
Copy link

@ticlazau ticlazau commented Mar 2, 2021

No description provided.

Adding Romanian language support
Adding Romanian language support
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #124 (92b197d) into master (f5cd730) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files           6        6           
  Lines         188      188           
=======================================
  Hits          182      182           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5cd730...46df85a. Read the comment docs.

@pjbull
Copy link
Member

pjbull commented Mar 4, 2021

@ticlazau amazing, thanks! Everything is in this PR, and I can close #122 and #123, correct?

Also, can you lowercase RO to ro? I think that's conventional for the ISO 639-1 codes: https://en.wikipedia.org/wiki/ISO_639-1

Changing the file name to match the country standard.
…s_ro.yml

Changing the file name to match the country standard.
@ticlazau ticlazau closed this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants