Adding attic support to fetch_osc_and_apply.sh #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrissW-R1
changed the title
mmd-osm
reviewed
Apr 11, 2017
| @@ -107,6 +107,10 @@ META_OPTION= | |||
| if [[ $2 == "--meta=yes" ]]; then | |||
| { | |||
| META_OPTION="--meta" | |||
| }; | |||
| elif [[ $2 == "--meta=attic" ]]; then | |||
| { | |||
There was a problem hiding this comment.
Could you please also update the help usage text in line 22? Thanks in advance.
mmd-osm
reviewed
Apr 11, 2017
| @@ -18,3 +18,5 @@ osmy_vigilance | |||
| init_database.sql | |||
| init_derived_data.sql | |||
|
|
|||
| /.idea/ | |||
There was a problem hiding this comment.
Somehow those unrelated changed made it into the pull request. Not a big issue, just wanted to make you aware of it.
There was a problem hiding this comment.
I know about it.
But I didn't want to create an extra branch for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, the script
fetch_osc_and_apply.shcould also started with parameter--meta=atticlike usage ofapply_osc_to_db.sh