TAC模式下，实现读已提交的隔离级别，并在 hmily-demo-tac-dubbo 模块增加对应测试案例 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…新增 HmilySelectSQLComputeEngine 类，用来执行 SELECT SQL, 查询对应记录的主键，用于获取全局锁。
cherrylzhao
reviewed
Jul 20, 2023
| /** | ||
| * Generate snapshot images. | ||
| * | ||
| * @param sql the sql | ||
| * @param sql the sql |
cherrylzhao
reviewed
Jul 20, 2023
| /** | ||
| * Execute query. | ||
| * | ||
| * @param connection connection | ||
| * @param sql sql | ||
| * @param sql sql |
|
代码质量很高，checkstyle简单改改，就可以合了 |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #356 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 435 442 +7
Lines 8455 8621 +166
Branches 1382 1417 +35
=======================================
- Misses 8455 8621 +166
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cherrylzhao
pushed a commit
that referenced
this pull request
Oct 24, 2023
* 在 HmilyExecuteTemplate 中, 增加对 SELECT SQL 的处理, 返回对应的 SelectStatement; 新增 HmilySelectSQLComputeEngine 类，用来执行 SELECT SQL, 查询对应记录的主键，用于获取全局锁。 * 在 hmily-demo-tac-dubbo 模块增加读已提交隔离级别的的测试案例 * checkstyle后, 代码格式简单调整
cherrylzhao
pushed a commit
that referenced
this pull request
Oct 24, 2023
* 在 HmilyExecuteTemplate 中, 增加对 SELECT SQL 的处理, 返回对应的 SelectStatement; 新增 HmilySelectSQLComputeEngine 类，用来执行 SELECT SQL, 查询对应记录的主键，用于获取全局锁。 * 在 hmily-demo-tac-dubbo 模块增加读已提交隔离级别的的测试案例 * checkstyle后, 代码格式简单调整
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn clean install -Dmaven.javadoc.skip=true.for issue #355