Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access to attitude rates #740

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cheintz
Copy link

@cheintz cheintz commented Jul 24, 2017

This seemed to be a good place for them, as they come in the Attitude MAVlink packet.

Resubmitting after rebasing on dronekit:master

@peterbarker
Copy link
Contributor

I think we should have separate objects and accessors for the rotation rates.

We don't conflate position and its first derivation velocity, so I can't see why we'd want to do it for attitude.

So basically an AttitudeRate object.

Does that make sense?

Ah, the argument "that's how MAVLink does it" isn't a great one, either. MAVLink (and its implementations) gets lots of stuff wrong, and dronekit-python is supposed to kinda fix these things :-)

@hamishwillee
Copy link
Contributor

FWIW Yes to an AttitudeRate object. Would be good if during implementation this could be added to the vehicle_state.py as the absolute bare minimum test.

@amilcarlucas
Copy link
Contributor

@cheintz any progress on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants