Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still maintained? #290

Open
levrik opened this issue Aug 18, 2020 · 22 comments
Open

Still maintained? #290

levrik opened this issue Aug 18, 2020 · 22 comments

Comments

@levrik
Copy link

levrik commented Aug 18, 2020

Over a year has passed since the comment in #242.
Any update here? Is it still being worked on?

@acamill
Copy link

acamill commented Sep 5, 2020

Same question, I think they are working on a V2 but not sure a public release his planned. last time I read issue they said they still use that internally

@hrueger
Copy link

hrueger commented Sep 6, 2020

I created a fork with the following changes:

  • TypeScript instead of CoffeeScript
  • Automation with GitHub Action
  • Typings for TS Projects
  • I18n

And some more exciting stuff ;-)

Will be finished in the next couple of days

@mkopinsky
Copy link

@hrueger that's great. Does i18n mean translations for feedback messages, custom dictionaries, both, or something else?

@acamill
Copy link

acamill commented Sep 7, 2020

@hrueger Nice, but having this repo being owned (and maintained) by Dropbox instead of third parties is also what makes it attractive also. What do you think about this?

@hrueger
Copy link

hrueger commented Sep 7, 2020

@mkopinsky

Does i18n mean translations for feedback messages, custom dictionaries, both, or something else?

both 😀
and custom keyboard layouts, too

@hrueger
Copy link

hrueger commented Sep 7, 2020

@acamill Sure, that's a good point. I just created my fork because

  • Angular complains about CommonJS dependencies so I needed an ES6 build
  • I wanted to be able to translate the feedback easily
  • I wanted a custom password / common words dictionary (German)

If they want to go to TypeScript, I can create a PR

@hrueger
Copy link

hrueger commented Sep 7, 2020

ES2015 Version published under zxcvbn3
Not completely finished yet

@acamill
Copy link

acamill commented Sep 8, 2020

Yhea.. Problem is dropbox did not update this repo in years

@niftylettuce
Copy link

niftylettuce commented Sep 11, 2020

we would love to use your i18n friendly fork in @forwardemail and @ladjs, please post an update here once it's released

@MuhammedZakir
Copy link

MuhammedZakir commented Sep 11, 2020

we would love to use your i18n friendly fork in @forwardemail and @ladjs, please post an update here once it's released

https://www.npmjs.com/package/zxcvbn3
https://github.com/hrueger/zxcvbn

#290 (comment):

ES2015 Version published under zxcvbn3
Not completely finished yet

@hrueger
Copy link

hrueger commented Sep 11, 2020

@niftylettuce I activated the issues module for my fork, so if you experience any problems, just create an issue there.
and thanks @MuhammedZakir for the quick response.

@MatthewAry
Copy link

It seems the principle developer @lowe is no longer with Dropbox (going off of LinkedIn here) and that this project is abandoned. zxcvbn is still well loved by the community but now it's time for someone else to pick up the torch.

@hrueger
Copy link

hrueger commented Nov 4, 2020

@MatthewAry
@MrWook and I are working together now. You can check the repo out here: https://github.com/MrWook/zxcvbn There's still work to be done, so contributions are welcome.

@sahithyandev
Copy link

If this project is abandoned, then any alternatives?

@MuhammedZakir
Copy link

If this project is abandoned, then any alternatives?

https://github.com/MrWook/zxcvbn

@sahithyandev
Copy link

@MuhammedZakir I read through the conversation and know about that fork. But not tried it yet. I will try it soon.

I asked for any other alternatives that are not zxcvbn based.

@MuhammedZakir
Copy link

@MuhammedZakir I read through the conversation and know about that fork. But not tried it yet. I will try it soon.

I asked for any other alternatives that are not zxcvbn based.

https://github.com/libpwquality/libpwquality (C & Python binding).

If you only need password validation, see https://www.passay.org/ (Java).

* I have never used either of them.

@sahithyandev
Copy link

@MuhammedZakir I will check them out. And I also decided to develop my own password strength estimator with TypeScript.

@MrWook
Copy link

MrWook commented Jan 5, 2021

Hey guys,

Like @hrueger mentioned we were in the process of rewriting this package and we finally finished and published it to npm.


Github: https://github.com/zxcvbn-ts/zxcvbn
npm: https://www.npmjs.com/package/@zxcvbn-ts/core


This is completely rewritten in typescript even the data-script part.



The scoring changed slightly duo to following changes:

  • Passwords as single tokens are now consistent rewarded for capitalization like in #232 described.
  • there are new keyboard layouts, qwertz and Dvorak
  • dates should be better recognized. At least the password list has more dates in them than before
  • the password list is newly generated. The script for this is using all matchers except for the dictionaries, this means that some passwords were included and now have different ranks which results in different guesses


Here is a list with key changes:

  • I18n support for feedback and dictionaries. By default, the feedback are keys now
  • All dictionaries are optional but highly recommend (wished feature in some issues)
  • Dictionaries are separated from the core library this means zxcvbn-ts is relative small without dictionaries
  • The project is a monorepo with a core library @zxcvbn-ts/core and language packages @zxcvbn-ts/language-en. At the beginning, there is only a German and an English language package.
  • Keyboard layouts can be customised. This means you can overwrite the default set of layouts with your own or extend it. For example if you develop a Russian website the keyboard layouts are pretty much useless.
    Now you could add a Russian keyboard layout by yourself for a fast implementation and create a PR for the long run.
  • Multiple keyboard layouts are used which means that every layout that is added to the library will be checked against by default.
  • Tests are now made with jest, so we get a coverage
  • Included eslint/prettier for consistent code
  • Added static-page docs https://zxcvbn-ts.github.io/zxcvbn/
  • There is an esm, commonJS and browser build use it as needed

I have some more ideas that I want to implement but first I want to increase the code and documentation quality.

For this reason I will create issues for my ideas and move some issues from this repo to zxcvbn-ts like the concern with separators. 

If you want to contribute, discuss changed that I made or anything else feel free to check out the repo. I activated the discussion panel.


I would love to see some feedback :)

@sahithyandev
Copy link

sahithyandev commented Jan 5, 2021

@MrWook
I will test it out tomorrow. And give you my feedback.
I hope it fits my needs so that I don't have to develop it again.

@williamdes
Copy link

williamdes commented Jun 20, 2021

Hi !

Thank you for the TS version, I did open an issue at phpMyAdmin so we can switch onto it.

Could you add a message on your repos @MrWook and @hrueger and archive them if they are not currently supported ?

@MrWook
Copy link

MrWook commented Jun 21, 2021

Hey @williamdes

My branch is only a fork of the original for a PR to add the zxcvbn-ts repo into the readme of the original even if it will never be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants