Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize cluster #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaoyao1991
Copy link

#21

@@ -0,0 +1,8 @@
-server
-Xms8g
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these settings make little sense for many types of hardware

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. These conf items are really dependent. We can put a better default here or we could just leave them as placeholder so that users can change these templates.

@fjy
Copy link
Member

fjy commented Nov 30, 2016

@xiaoyao1991 it doesn't look like this docker druid will actually work for a single node setup

@xiaoyao1991
Copy link
Author

xiaoyao1991 commented Nov 30, 2016

@fjy Right. This is for having different images for different node types. One can still refer to the setup in the all-in-one folder for a single node setup though.

@fjy
Copy link
Member

fjy commented Dec 2, 2016

@xiaoyao1991 can we add some docs about example hardware for these docker configs? i think they match what we propose in the clustered docs

@xiaoyao1991
Copy link
Author

@fjy Sure, and in fact, I copied the configs from https://github.com/druid-io/druid/tree/master/examples/conf/druid. Should I simply say refer to the http://druid.io/docs/latest/configuration/production-cluster.html for the docs that you are suggesting?

Actually, my expectation on this is that users should pull these templates and reconfigure before running. These images are not in the docker hub anyway(since I don't have the permission to druidio namespace), so no way people can pull these images from somewhere and use them directly. Every user will have their own settings, including how they wish to ingest data(which is not covered in this PR). The templates in this PR only provide a layout for a containerized druid cluster. What do you think?

@fjy
Copy link
Member

fjy commented Dec 10, 2016

@xiaoyao1991 can we add docs on minimum hardware required for the remote cluster to work?

@pantaoran
Copy link

It's a pity that this never got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants