drush dl (--gitsubmodule) downloads extra pieces into /modules (and points there with .gitmodules) when symlinked parent dir #566
Conversation
|
I'll point out that one late comment there asked for more tests. |
weitzman
changed the title
|
Well at least, it's working on my local |
|
Hi @weitzman, could you please take a look on this? What needs to be done in order to fix the issue? |
|
The PM component is managed by @jonhattan. |
|
@jonhattan Could you please tell me what needs to be done to release my fix? Thanks. |
|
@jonhattan What is missing here? I am using this patch since more than two years without any issues. |
|
Well I have been negligent to add tests for scenarios with symlinks. Since this change only affects git_drupalorg engine, we can go ahead and merge it. Sorry for the delay. |
drush dl (--gitsubmodule) downloads extra pieces into /modules (and points there with .gitmodules) when symlinked parent dir
|
Wow, this was fast :) |
|
Submodules are broken on 6.x too whenever full absolute paths aren't already being used -- the same patch/fix applies. Can you cherry-pick for 6 please? |
|
Cherry picked from 6.x and 5.x |
See https://drupal.org/node/1372442#comment-6099598 for more details.