-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADUser: add SamAccountName parameter #660
base: main
Are you sure you want to change the base?
Conversation
Fix New-ADUser to use '-Name' instead of '-SamAccountName' for specifying the user account name. Change parameter descriptions to clarify that UserName can be more than just SamAccountName.
Add SamAccountName property to allow setting the name of the user; this requires that the UserName property be specified with something other than the SamAccountName (e.g., the SID, DN, &c.).
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
===================================
Coverage 98% 98%
===================================
Files 25 25
Lines 3408 3408
===================================
Hits 3340 3340
Misses 68 68 |
I don't have integration tests in here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs integration tests.
Have you tested this change through the full lifecycle of an ADUser object and this additional property? i.e. addition, modification and deletion of an ADUser with and without this property, and addition, modification and deletion of this property. This must be a non-breaking change to current usage of this resource.
Reviewable status: 0 of 5 files reviewed, all discussions resolved
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again. |
Pull Request (PR) description
Adds optional parameter SamAccountName to ADUser resource to allow setting this property separately. This requires that UserName be specified using something other than the SamAccountName, e.g. SID, DN, UPN, &c.
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is