Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADUser: add SamAccountName parameter #660

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gaelicWizard
Copy link

@gaelicWizard gaelicWizard commented May 22, 2021

Pull Request (PR) description

Adds optional parameter SamAccountName to ADUser resource to allow setting this property separately. This requires that UserName be specified using something other than the SamAccountName, e.g. SID, DN, UPN, &c.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

gaelicWizard and others added 3 commits May 20, 2021 00:32
Fix New-ADUser to use '-Name' instead of '-SamAccountName' for specifying the user account name. Change parameter descriptions to clarify that UserName can be more than just SamAccountName.
Add SamAccountName property to allow setting the name of the user; this requires that the UserName property be specified with something other than the SamAccountName (e.g., the SID, DN, &c.).
@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #660 (48b01e1) into main (9346a1d) will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #660   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3408           
===================================
  Hits       3340   3340           
  Misses       68     68           

@gaelicWizard
Copy link
Author

I don't have integration tests in here

@gaelicWizard gaelicWizard marked this pull request as ready for review May 23, 2021 01:12
@johlju johlju added the needs review The pull request needs a code review. label May 27, 2021
Copy link
Contributor

@X-Guardian X-Guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs integration tests.

Have you tested this change through the full lifecycle of an ADUser object and this additional property? i.e. addition, modification and deletion of an ADUser with and without this property, and addition, modification and deletion of this property. This must be a non-breaking change to current usage of this resource.

Reviewable status: 0 of 5 files reviewed, all discussions resolved

@X-Guardian X-Guardian added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Jul 4, 2021
@stale
Copy link

stale bot commented Jul 19, 2021

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@stale stale bot added the abandoned The pull request has been abandoned. label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned. waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants