-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PfxImport: Add empty string password to .Import method #259
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
===================================
Coverage 84% 84%
===================================
Files 7 7
Lines 933 933
===================================
Hits 790 790
Misses 143 143
|
Does anyone know what needs to be changed with the PR to get it merged? I'm running into this issue (#258) so it would be nice go get it merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cmielke)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works ok
Hi @cmielke - any chance you could rebase this against main? There have been a few fixes/changes to the pipeline. This should fix the build process so that all the tests pass. Thank you! |
I have rebased against main. Hopefully that will work. |
Pull Request (PR) description
Add an empty string to the X509Certificate2.Import to prevent the MethodCountCouldNotFindBest exception when using a null password to import the PFX certificate.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is