Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: WSManListener: Convert to a Class Resource #106

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

dan-hughes
Copy link
Contributor

@dan-hughes dan-hughes commented Sep 18, 2024

Pull Request (PR) description

Convert WSManListener to a class resource
Rename parameter DN to BaseDN

This Pull Request (PR) fixes the following issues

Contributes to #98
Fixes #89

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 98.43750% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98%. Comparing base (4856433) to head (514c668).

Files with missing lines Patch % Lines
source/Classes/020.WSManListener.ps1 98% 1 Missing ⚠️
source/Private/Find-Certificate.ps1 97% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #106   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files         3      7    +4     
  Lines       292    198   -94     
===================================
- Hits        288    196   -92     
+ Misses        4      2    -2     
Files with missing lines Coverage Δ
.../DSCResources/DSC_WSManConfig/DSC_WSManConfig.psm1 100% <ø> (ø)
...DSC_WSManServiceConfig/DSC_WSManServiceConfig.psm1 100% <ø> (ø)
source/Private/Get-DefaultPort.ps1 100% <100%> (ø)
source/Private/Get-Listener.ps1 100% <100%> (ø)
source/prefix.ps1 100% <100%> (ø)
source/Classes/020.WSManListener.ps1 98% <98%> (ø)
source/Private/Find-Certificate.ps1 97% <97%> (ø)

@PlagueHO PlagueHO self-assigned this Oct 26, 2024
@dan-hughes dan-hughes marked this pull request as ready for review November 17, 2024 17:37
@dan-hughes
Copy link
Contributor Author

@PlagueHO, finally ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WSManListener parameter DN should be BaseDN
2 participants