New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nowrap.c - reorder variadic macros #4

Open

jonyesno wants to merge 1 commit into dse:master from jonyesno:nowrap-variadic-fix

jonyesno commented Apr 26, 2023

... so that va_end comes after vsnprintf's use of ap.

Otherwise an optimising compiler can produce code that segfaults.

I don't know enough about compilers to know why, though this updated va_start -> vsnprintf -> va_end sequence feels appropriate.

Context: I was writing a FreeBSD port for tdu and it defaults to -O2 on non-debug builds.

Thanks for tdu!


          nowrap - re-order va_end to come after vsnprintf

4745a7a

otherwise `vsnsprintf` segfaults under some compiler optimisation
settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet