Refactor: WasmConfig, Layer implementation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add wasm-pack-action - comment unused crate in tests for lint
Semantically cleaner, it's a nit
- Denest Layer::on_event
dsgallups
commented
Dec 18, 2024
tests/wasm.rs
Outdated
| @@ -0,0 +1,9 @@ | |||
| use wasm_bindgen_test::*; | |||
| //use wasm_tracing::prelude::*; | |||
sd2k
added a commit
to grafana/augurs
that referenced
this pull request
Dec 18, 2024
The 1.0 update improves the APIs and includes a helpful change to omit the origin (line number, file name) from the logs (dsgallups/wasm-tracing#11).
sd2k
added a commit
to grafana/augurs
that referenced
this pull request
Dec 18, 2024
The 1.0 update improves the APIs and includes a helpful change to omit the origin (line number, file name) from the logs (dsgallups/wasm-tracing#11).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
WASMLayer->WasmLayerRenamed
WasmLayerConfig->WasmLayerConfigReplaced
WasmLayerConfig::report_logs_in_consoleandWasmLayerConfig::use_console_colorwithWasmLayerConfig::consoleConsoleConfigenumAdded documentation
Publicly reexport all structs to root