-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Stochastic Integration Filter #1040
Conversation
Fixing merge conflicts arising from CKF implementation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
+ Coverage 93.69% 93.77% +0.07%
==========================================
Files 212 212
Lines 13881 14048 +167
Branches 1922 1931 +9
==========================================
+ Hits 13006 13173 +167
Misses 623 623
Partials 252 252
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great contribution.
There are some tests missing for smoother and updater. These could be easily added similar to how you've done for predictor.
I wonder if you could make some common code for the multiple recursions, as code is very similar, but minor variations? (You'll see from my suggestions, that many are same for similar code in these recursion parts)
Added unit testing for various SIF related modules.
Changed line in SIF Updater to use matrix broadcasting. Co-authored-by: Steven Hiscocks <[email protected]>
Simplified check on SIF updater and added in place operation for speed. Co-authored-by: Steven Hiscocks <[email protected]>
Used matrix broadcasting in SIF Updater in place of depriciated np.matrix operation. Co-authored-by: Steven Hiscocks <[email protected]>
Converted SIF Updater to inplace operations for speed. Co-authored-by: Steven Hiscocks <[email protected]>
Removed unneccisary parenthesis from SIF Updater Co-authored-by: Steven Hiscocks <[email protected]>
Fixed typo in Stochastic Integration Smoother Co-authored-by: Henry Pritchett <[email protected]>
Fixed typo in Stochastic Cubature Rule function comment Co-authored-by: Henry Pritchett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some final documentation points and naming conventions, after this it looks good to merge (to me at least!)
Thanks :)
Henry
Revised SIF updater docstring Co-authored-by: Henry Pritchett <[email protected]>
fixed typo in SIF predictor docstring Co-authored-by: Henry Pritchett <[email protected]>
Fixed typo on line 1067 of SIF built in function Co-authored-by: Henry Pritchett <[email protected]>
Fixed typo on line 972 of SIF built in function Co-authored-by: Henry Pritchett <[email protected]>
Corrected import statment in kalman smoother file pertaining to SIF
Corrected import statment in kalman predictor file pertaining to SIF
Corrected import statment in kalman updater file pertaining to SIF
Fixed incorrect function name in SIF Smoother
Fixed incorrect function name in SIF predictor
Fixed incorrect function name in SIF Updater
Could you take a look at the latest changes? I believe it should be ready to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! Happy to approve this :)
Thanks,
Henry
Hello all, I am presenting an implementation of the Stochastic Integration Filter for review.
The implementation was primarily authored by Jakub Matousek and revised/edited by myself for an upcoming paper for Fusion 2024.
The implementation includes a Predictor, an updator, as well as some functions which perform the stochastic integration scheme itself.
Also as background on the method itself, here are two papers. The first one details the algorithm itself, but the second I feel gives more background on the algorithm itself and contains compairison to other methods.
1.Dunik J, Straka O, Simandl M. Stochastic Integration Filter. IEEE transactions on automatic control. 2013;58(6):1561-1566. doi:10.1109/TAC.2013.2258494
2 .Dunik J, Straka O, Simandl M, Blasch E. Random-point-based filters: analysis and comparison in target tracking. IEEE tr