Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2880 point2grid qc #2984

Merged
merged 23 commits into from
Oct 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
fe24056
Per #2880, remove Point2Grid quality_mark_thresh config option and ad…
JohnHalleyGotway Jun 24, 2024
2ac2448
Per #2880, update point2grid docs and reformat whitespace throughout.
JohnHalleyGotway Jun 24, 2024
c789a22
Per #2880, remove quality_mark_thresh and add obs_quality_inc and obs…
JohnHalleyGotway Jun 24, 2024
00abe8d
Merge remote-tracking branch 'origin/develop' into feature_2880_point…
JohnHalleyGotway Sep 13, 2024
e04a26c
Merge remote-tracking branch 'origin/develop' into feature_2880_point…
JohnHalleyGotway Sep 16, 2024
2d49f68
Unrelated to #2880, fix formatting of this R-string which cannot incl…
JohnHalleyGotway Sep 18, 2024
9ca8362
Merge remote-tracking branch 'origin/develop' into feature_2880_point…
JohnHalleyGotway Sep 19, 2024
e95cc01
Merge remote-tracking branch 'origin/develop' into feature_2880_point…
JohnHalleyGotway Sep 20, 2024
deddf97
Per #2880, not working quite right yet but this is progress
JohnHalleyGotway Sep 20, 2024
58b3463
Merge remote-tracking branch 'origin/develop' into feature_2880_point…
JohnHalleyGotway Sep 30, 2024
baa5af1
Per #2880, add a write_css(IntArray) utility function.
JohnHalleyGotway Oct 1, 2024
cbf60bf
Per #2880, update NcPointObsData class to read the obs quality values…
JohnHalleyGotway Oct 1, 2024
6dea58e
Per #2880, update the log message about the quality control filter o…
JohnHalleyGotway Oct 1, 2024
6ad7d73
Per #2880, tweak log messages.
JohnHalleyGotway Oct 1, 2024
73ae273
Per #2880, tweak log messages.
JohnHalleyGotway Oct 1, 2024
481bd99
Per #2880, add a Point2Grid unit test to demonstrate using the obs_qu…
JohnHalleyGotway Oct 1, 2024
b082e7d
Per #2880, declare these get accessor functions as const to avoid Son…
JohnHalleyGotway Oct 1, 2024
72d9653
Per #2880, many changes to the vx_nc_obs library and point2grid appli…
JohnHalleyGotway Oct 1, 2024
9e9a171
Per #2880, fix compilation error.
JohnHalleyGotway Oct 2, 2024
b1e06dc
Per #2880, fix compilation error
JohnHalleyGotway Oct 2, 2024
0c5d72b
Per #2880, revert skip_times back to vector<bool> since I wasn't post…
JohnHalleyGotway Oct 2, 2024
ba5f4a4
Per #2880, rename the -qc command line option as -goes_qc, but still …
JohnHalleyGotway Oct 2, 2024
315d409
Per #2880, based on guidance from @hsoh, reset the var_cell_mapping v…
JohnHalleyGotway Oct 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions data/config/Point2GridConfig_default
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@ obs_window = {

////////////////////////////////////////////////////////////////////////////////


//
// Observation message type
// Point observation filtering options
//
message_type = [];
message_type = [];
obs_quality_inc = [];
obs_quality_exc = [];

////////////////////////////////////////////////////////////////////////////////

Expand Down Expand Up @@ -72,10 +73,6 @@ var_name_map = [

////////////////////////////////////////////////////////////////////////////////

quality_mark_thresh = 2;

////////////////////////////////////////////////////////////////////////////////

tmp_dir = "/tmp";
version = "V12.0.0";

Expand Down
431 changes: 169 additions & 262 deletions docs/Users_Guide/reformat_point.rst

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions internal/test_unit/config/Point2GridConfig_WINDS
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
obs_quality_inc = [ "2" ];
obs_quality_exc = [ "1" ];
11 changes: 4 additions & 7 deletions internal/test_unit/config/Point2GridConfig_valid_time
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@ valid_time = "20201022_173000";

////////////////////////////////////////////////////////////////////////////////


//
// Observation message type
// Point observation filtering options
//
//message_type = [];
message_type = [];
obs_quality_inc = [];
obs_quality_exc = [];

////////////////////////////////////////////////////////////////////////////////

Expand Down Expand Up @@ -72,10 +73,6 @@ valid_time = "20201022_173000";

////////////////////////////////////////////////////////////////////////////////

//quality_mark_thresh = 2;

////////////////////////////////////////////////////////////////////////////////

tmp_dir = "/tmp";
version = "V12.0.0";

Expand Down
28 changes: 23 additions & 5 deletions internal/test_unit/xml/unit_point2grid.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,23 @@
</output>
</test>

<test name="point2grid_pb2nc_WINDS">
<exec>&MET_BIN;/point2grid</exec>
<param> \
&OUTPUT_DIR;/pb2nc/ndas.20120409.t12z.prepbufr.tm00.nc \
G212 \
&OUTPUT_DIR;/point2grid/pb2nc_WINDS.nc \
-field 'name="UGRD"; level="*";' \
-field 'name="VGRD"; level="*";' \
-name UWIND,VWIND \
-config &CONFIG_DIR;/Point2GridConfig_WINDS \
-v 3
</param>
<output>
<grid_nc>&OUTPUT_DIR;/point2grid/pb2nc_WINDS.nc</grid_nc>
</output>
</test>

<test name="point2grid_pb2nc_TMP">
<exec>&MET_BIN;/point2grid</exec>
<param> \
Expand Down Expand Up @@ -130,7 +147,7 @@
G212 \
&OUTPUT_DIR;/point2grid/point2grid_GOES_16_AOD_TO_G212_compute.nc \
-field 'name="AOD"; level="(*,*)";' \
-qc 0,1 -method MAX \
-goes_qc 0,1 -method MAX \
-v 1
</param>
<output>
Expand Down Expand Up @@ -167,7 +184,7 @@
&OUTPUT_DIR;/point2grid/point2grid_GOES_16_ADP.nc \
-field 'name="AOD_Smoke"; level="(*,*)";' \
-adp &DATA_DIR_MODEL;/goes_16/OR_ABI-L2-ADPC-M6_G16_s20192662141196_e20192662143569_c20192662144526.nc \
-qc 0,1 -method MAX \
-goes_qc 0,1 -method MAX \
-v 1
</param>
<output>
Expand All @@ -185,7 +202,7 @@
G212 \
&OUTPUT_DIR;/point2grid/point2grid_GOES_16_AOD_TO_G212_grid_map.nc \
-field 'name="AOD"; level="(*,*)";' \
-qc 0,1,2 -method MAX \
-goes_qc 0,1,2 -method MAX \
-v 1
</param>
<output>
Expand All @@ -205,7 +222,7 @@
G212 \
&OUTPUT_DIR;/point2grid/point2grid_GOES_16_AOD_TO_G212.nc \
-field 'name="AOD"; level="(*,*)";' \
-qc 0,1,2 -method MAX \
-goes_qc 0,1,2 -method MAX \
-v 1
</param>
<output>
Expand All @@ -224,7 +241,7 @@
&OUTPUT_DIR;/point2grid/point2grid_GOES_16_ADP_Enterprise_high.nc \
-field 'name="AOD_Smoke"; level="(*,*)";' \
-adp &DATA_DIR_MODEL;/goes_16/OR_ABI-L2-ADPC-M6_G16_s20241100001171_e20241100003544_c20241100006361.nc \
-qc 0,1 -method MAX \
-goes_qc 0,1 -method MAX \
-v 1
</param>
<output>
Expand Down Expand Up @@ -319,6 +336,7 @@
</output>
</test>

<!-- Use the old -qc option to test backward compatibility -->
<test name="point2grid_GOES_16_AOD_TO_G212_unsigned">
<exec>&MET_BIN;/point2grid</exec>
<env>
Expand Down
1 change: 0 additions & 1 deletion src/basic/vx_util/crc_array.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include <vector>

#include "num_array.h"
#include "int_array.h"
#include "is_bad_data.h"
#include "nint.h"
#include "vx_cal.h"
Expand Down
8 changes: 6 additions & 2 deletions src/basic/vx_util/int_array.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

#include <iostream>

#include "num_array.h"

#include "crc_array.h"


Expand All @@ -34,6 +32,12 @@ typedef CRC_Array<int> IntArray;
////////////////////////////////////////////////////////////////////////


extern ConcatString write_css(const IntArray &);


////////////////////////////////////////////////////////////////////////


#endif /* __INT_ARRAY_H__ */


Expand Down
20 changes: 20 additions & 0 deletions src/basic/vx_util/num_array.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

#include "num_array.h"

#include "int_array.h"
#include "is_bad_data.h"
#include "ptile.h"
#include "nint.h"
Expand Down Expand Up @@ -1382,3 +1383,22 @@ ConcatString write_css_hhmmss(const NumArray &na)


////////////////////////////////////////////////////////////////////////


ConcatString write_css(const IntArray &ia)

{

ConcatString css;

for ( int i=0; i<ia.n(); ++i ) {
css << (i == 0 ? "" : ",") << ia[i];
}

return css;

}


////////////////////////////////////////////////////////////////////////

Loading
Loading