Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix flakiness in apple music adapter test: ensure non-zero test-content #1412

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

jzacsh
Copy link
Collaborator

@jzacsh jzacsh commented Dec 9, 2024

the arrangement logic accidentally guaranteed a 1/100 chance we would get a failure (range was [0,100) but we want [1,...) instead)

fixed #1411

@jzacsh jzacsh requested a review from seehamrun December 9, 2024 23:40
@jzacsh jzacsh force-pushed the fix-applemusic-flaky-test branch from a9bde91 to cd5bc7a Compare December 9, 2024 23:57
Copy link
Member

@lisad lisad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be slightly clearer "ensure this test setup actually runs " but overall it makes sense anyway

@jzacsh jzacsh merged commit 4716397 into dtinit:master Dec 10, 2024
5 checks passed
@jzacsh jzacsh deleted the fix-applemusic-flaky-test branch December 10, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: intermitent test failures in apple adapter, when not touching that codepath
2 participants