-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add logo support to QR code API using <img> tag as a workaround #1321
Conversation
@BharathxD is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@vercel/[email protected] |
@BharathxD you sir are a wizard |
Awarding BharathxD: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/BharathxD |
Glad to Help! 😂🙌🏻 |
Add logo support to QR code API using
<img>
tag workaroundSummary
This PR adds logo support to the QR code API by using an
<img>
tag as a workaround, which fixes the issue #1301Changes
<img>
tag instead of an SVG<image>
element. This serves as a workaround for the rendering issue described in vercel/satori#592.Motivation
<img>
tag workaround bypasses the rendering issues with the SVG<image>
tag in the current environment.Testing
References