Add ability to pass vendored feature to openssl in libduckdb-sys #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muralisoundararajan
force-pushed
the
openssl-vendored
branch
2 times, most recently
from
72e0daa
to
f199257
Compare
muralisoundararajan
force-pushed
the
openssl-vendored
branch
from
f199257
to
fd11953
Compare
Mause
approved these changes
Jun 6, 2024
|
@Mause Thanks for the review. CI pipeline is failing with the same reason as main line due to new version of OpenSSL 3.3.1 available in choco and runner-images for Windows is using the previous version. By any chance, would it be possible to wait for this week duckdb release to wait till we have this issue is resolved, so that this PR can be part of the release? |
|
@muralisoundararajan Its not obvious to me how to solve this issue (googling for this gives me no results). Could you share some more information from your investigation? Is this just a problem with choco that we have to wait for them to fix or can we adjust something in our CI pipeline to resolve it? I suspect we can maybe remove the choco openssl install completely and just rely on the openssl version provided by the runner environment? |
|
Actually, I think I fixed it in #327 |
muralisoundararajan
force-pushed
the
openssl-vendored
branch
from
fd11953
to
28afabb
Compare
|
@Maxxen Yes, that seem to resolve the issue. Thanks for the quick turnaround. I rebased my changes, would it be possible to run the CI workflow. |
|
Another option I was contemplating was to use openssl_vendored in msvc environment during the failure. |
|
Thanks! Sorry for the friction :) |
robert3005
referenced
this pull request
in spiraldb/vortex
Jul 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [duckdb](https://togithub.com/wangfenjin/duckdb-rs) | workspace.dependencies | major | `0.10.2` -> `1.0.0` | --- ### Release Notes <details> <summary>wangfenjin/duckdb-rs (duckdb)</summary> ### [`v1.0.0`](https://togithub.com/duckdb/duckdb-rs/releases/tag/v1.0.0) [Compare Source](https://togithub.com/wangfenjin/duckdb-rs/compare/v0.10.2...v1.0.0) This release upgrades the shipped DuckDB to v1.0.0, in addition to a number of bug fixes. **Note**: The `httpfs` module that ships the `httpfs` extension is removed in this release. The `httpfs` extension can instead be used through DuckDB's native extension installation/loading mechanism. #### What's Changed - feat: support "large" arrow data types by [@​Mause](https://togithub.com/Mause) in [https://github.com/duckdb/duckdb-rs/pull/307](https://togithub.com/duckdb/duckdb-rs/pull/307) - Fixes the issue ignoring nulls when copy from arrow array to flat vector by [@​y-f-u](https://togithub.com/y-f-u) in [https://github.com/duckdb/duckdb-rs/pull/316](https://togithub.com/duckdb/duckdb-rs/pull/316) - change SQLite to DuckDB by [@​era127](https://togithub.com/era127) in [https://github.com/duckdb/duckdb-rs/pull/308](https://togithub.com/duckdb/duckdb-rs/pull/308) - Organise workspace crates and consolidate Cargo.toml manifest properties/dependencies by [@​Swoorup](https://togithub.com/Swoorup) in [https://github.com/duckdb/duckdb-rs/pull/285](https://togithub.com/duckdb/duckdb-rs/pull/285) - Update README.md by [@​yoonghm](https://togithub.com/yoonghm) in [https://github.com/duckdb/duckdb-rs/pull/242](https://togithub.com/duckdb/duckdb-rs/pull/242) - Add support for DuckDB arrays when using Arrow's FixedSizeList by [@​Jeadie](https://togithub.com/Jeadie) in [https://github.com/duckdb/duckdb-rs/pull/323](https://togithub.com/duckdb/duckdb-rs/pull/323) - Add support for BinaryArray in arrow-vtab by [@​phillipleblanc](https://togithub.com/phillipleblanc) in [https://github.com/duckdb/duckdb-rs/pull/324](https://togithub.com/duckdb/duckdb-rs/pull/324) - use openssl from runner by [@​Maxxen](https://togithub.com/Maxxen) in [https://github.com/duckdb/duckdb-rs/pull/327](https://togithub.com/duckdb/duckdb-rs/pull/327) - Add ability to pass vendored feature to openssl in libduckdb-sys by [@​muralisoundararajan](https://togithub.com/muralisoundararajan) in [https://github.com/duckdb/duckdb-rs/pull/321](https://togithub.com/duckdb/duckdb-rs/pull/321) - Implement appender for date/time types by [@​rijkvp](https://togithub.com/rijkvp) in [https://github.com/duckdb/duckdb-rs/pull/313](https://togithub.com/duckdb/duckdb-rs/pull/313) - Support decimal128 without casting to double by [@​Maxxen](https://togithub.com/Maxxen) in [https://github.com/duckdb/duckdb-rs/pull/328](https://togithub.com/duckdb/duckdb-rs/pull/328) - feat: experimental support for further nested types by [@​Mause](https://togithub.com/Mause) in [https://github.com/duckdb/duckdb-rs/pull/318](https://togithub.com/duckdb/duckdb-rs/pull/318) - upgrade arrow-rs to 52 by [@​Mause](https://togithub.com/Mause) in [https://github.com/duckdb/duckdb-rs/pull/332](https://togithub.com/duckdb/duckdb-rs/pull/332) - Expose the underlying schema of executed statement by [@​abhiaagarwal](https://togithub.com/abhiaagarwal) in [https://github.com/duckdb/duckdb-rs/pull/333](https://togithub.com/duckdb/duckdb-rs/pull/333) - Remove mut from raw_query by [@​rijkvp](https://togithub.com/rijkvp) in [https://github.com/duckdb/duckdb-rs/pull/339](https://togithub.com/duckdb/duckdb-rs/pull/339) - Support Arrow type `LargeUtf8`. by [@​Jeadie](https://togithub.com/Jeadie) in [https://github.com/duckdb/duckdb-rs/pull/341](https://togithub.com/duckdb/duckdb-rs/pull/341) - Update duckdb-rs to DuckDB v1.0.0 by [@​Mytherin](https://togithub.com/Mytherin) in [https://github.com/duckdb/duckdb-rs/pull/336](https://togithub.com/duckdb/duckdb-rs/pull/336) - fix: don't write files outside of `OUT_DIR` by [@​frectonz](https://togithub.com/frectonz) in [https://github.com/duckdb/duckdb-rs/pull/347](https://togithub.com/duckdb/duckdb-rs/pull/347) - Remove built-in HTTPFS extension and fix Windows CI by [@​Mytherin](https://togithub.com/Mytherin) in [https://github.com/duckdb/duckdb-rs/pull/353](https://togithub.com/duckdb/duckdb-rs/pull/353) - Upgrade duckdb-loadable-macros to 0.1.2 by [@​Mytherin](https://togithub.com/Mytherin) in [https://github.com/duckdb/duckdb-rs/pull/354](https://togithub.com/duckdb/duckdb-rs/pull/354) #### New Contributors - [@​y-f-u](https://togithub.com/y-f-u) made their first contribution in [https://github.com/duckdb/duckdb-rs/pull/316](https://togithub.com/duckdb/duckdb-rs/pull/316) - [@​era127](https://togithub.com/era127) made their first contribution in [https://github.com/duckdb/duckdb-rs/pull/308](https://togithub.com/duckdb/duckdb-rs/pull/308) - [@​muralisoundararajan](https://togithub.com/muralisoundararajan) made their first contribution in [https://github.com/duckdb/duckdb-rs/pull/321](https://togithub.com/duckdb/duckdb-rs/pull/321) - [@​rijkvp](https://togithub.com/rijkvp) made their first contribution in [https://github.com/duckdb/duckdb-rs/pull/313](https://togithub.com/duckdb/duckdb-rs/pull/313) - [@​abhiaagarwal](https://togithub.com/abhiaagarwal) made their first contribution in [https://github.com/duckdb/duckdb-rs/pull/333](https://togithub.com/duckdb/duckdb-rs/pull/333) - [@​frectonz](https://togithub.com/frectonz) made their first contribution in [https://github.com/duckdb/duckdb-rs/pull/347](https://togithub.com/duckdb/duckdb-rs/pull/347) **Full Changelog**: duckdb/duckdb-rs@v0.10.2...v1.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/spiraldb/vortex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Robert Kruszewski <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openssl module imported from rust-openssl provides an ability to use vendored openssl as a feature. In libduckdb-sys, when it is introduced as module, the ability to provide "vendored" feature was not added to libduckdb-sys and duckdb crates.
This change adds ability to pass "vendored" feature to "openssl" module within the "libduckdb-sys"
Resolves #320