Merge branch 'hotfix/5.201.1'

duckduckgo · May 20, 2024 · 18d8eeb · 18d8eeb
2 parents 6d8acec + fa7740c
commit 18d8eeb
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/app/version/version.properties b/app/version/version.properties
@@ -1 +1 @@
-VERSION=5.201.0
+VERSION=5.201.1
diff --git a/.../src/main/java/com/duckduckgo/autofill/impl/engagement/EngagementPasswordAddedListener.kt b/.../src/main/java/com/duckduckgo/autofill/impl/engagement/EngagementPasswordAddedListener.kt
@@ -38,7 +38,15 @@ class EngagementPasswordAddedListener @Inject constructor(
     private val pixel: Pixel,
 ) : PasswordStoreEventListener {
 
+    // keep in-memory state to avoid sending the pixel multiple times if called repeatedly in a short time
+    private var credentialAdded = false
+
+    @Synchronized
     override fun onCredentialAdded(id: Long) {
+        if (credentialAdded) return
+
+        credentialAdded = true
+
         appCoroutineScope.launch(dispatchers.io()) {
             val daysInstalled = userBrowserProperties.daysSinceInstalled()
             Timber.v("onCredentialAdded. daysInstalled: $daysInstalled")

diff --git a/.../test/java/com/duckduckgo/autofill/impl/engagement/EngagementPasswordAddedListenerTest.kt b/.../test/java/com/duckduckgo/autofill/impl/engagement/EngagementPasswordAddedListenerTest.kt
@@ -31,7 +31,7 @@ class EngagementPasswordAddedListenerTest {
     fun whenDaysInstalledLessThan7ThenPixelSent() {
         whenever(userBrowserProperties.daysSinceInstalled()).thenReturn(0)
         testee.onCredentialAdded(0)
-        verifyPixelSent()
+        verifyPixelSentOnce()
     }
 
     @Test
@@ -48,7 +48,16 @@ class EngagementPasswordAddedListenerTest {
         verifyPixelNotSent()
     }
 
-    private fun verifyPixelSent() {
+    @Test
+    fun whenCalledMultipleTimesThenOnlySendsPixelOnce() {
+        whenever(userBrowserProperties.daysSinceInstalled()).thenReturn(0)
+        repeat(10) {
+            testee.onCredentialAdded(0)
+        }
+        verifyPixelSentOnce()
+    }
+
+    private fun verifyPixelSentOnce() {
         verify(pixel).fire(AUTOFILL_ENGAGEMENT_ONBOARDED_USER, type = UNIQUE)
     }