Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the bodyLimit to 50MB from 1MB #384

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 10, 2024

In this PR:

  • Bug fix (non-breaking change which fixes an issue)

Issues reference:

Related: #366

I have a library that is 3.3MB right now, and I kinda "arbitrarily" chose 50MB, but I figure if some build assets could include images, it may be good to bump further.

Any larger than that though, and... folks should probably statically host those images somewhere.


Alternatively, I see (in #366) there is a BODY_LIMIT environment variable -- must be a fastify thing 😅

I was not able to find that in fastify's docs though?

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
    • aside from the minio test -- address already in use error
  • Have you commit using Conventional Commits?

@fox1t
Copy link
Collaborator

fox1t commented Jun 11, 2024

You can find all of the env vars supported by remote cache here. https://ducktors.github.io/turborepo-remote-cache/environment-variables

Btw I think this is a sane change and we are going to merge this.

@fox1t fox1t merged commit 2cb846b into ducktors:main Jun 11, 2024
21 checks passed
@fox1t fox1t mentioned this pull request Jun 11, 2024
@matteovivona
Copy link
Collaborator

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matteovivona
Copy link
Collaborator

@all-contributors add @NullVoxPopuli on code

@matteovivona
Copy link
Collaborator

Related to this issue #323

Copy link
Contributor

@matteovivona

I've put up a pull request to add @NullVoxPopuli! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants