Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to old documentation #126

Merged
merged 2 commits into from
May 10, 2024
Merged

Update references to old documentation #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a5227d
Update references to old documentation
RichardKeo May 10, 2024
c017c07
another change of datetime format in result data
bh2smith May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dune_client/api/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
""""
Basic Dune Client Class responsible for refreshing Dune Queries
Framework built on Dune's API Documentation
https://duneanalytics.notion.site/API-Documentation-1b93d16e0fa941398e15047f643e003a
https://docs.dune.com/api-reference/overview/introduction
"""

from __future__ import annotations
Expand Down
2 changes: 1 addition & 1 deletion dune_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
""""
Basic Dune Client Class responsible for refreshing Dune Queries
Framework built on Dune's API Documentation
https://duneanalytics.notion.site/API-Documentation-1b93d16e0fa941398e15047f643e003a
https://docs.dune.com/api-reference/overview/introduction
"""

from dune_client.api.extensions import ExtendedAPI
Expand Down
8 changes: 4 additions & 4 deletions tests/e2e/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def test_parameters_recognized(self):
{
"text_field": "different word",
"number_field": 22,
"date_field": "1991-01-01 00:00:00.000",
"date_field": "1991-01-01 00:00:00",
"list_field": "Option 2",
}
],
Expand Down Expand Up @@ -376,7 +376,7 @@ def test_download_csv_success_by_id(self):
{
"text_field": "different word",
"number_field": 22,
"date_field": "1991-01-01 00:00:00.000",
"date_field": "1991-01-01 00:00:00",
"list_field": "Option 2",
}
],
Expand All @@ -391,14 +391,14 @@ def test_download_csv_success_with_params(self):
# Note that we could compare results with
# ",".join([p.value for p in self.query.parameters()]) + "\n"
# but there seems to be a discrepancy with the date string values.
# Specifically 1991-01-01 00:00:00.000
# Specifically 1991-01-01 00:00:00
# vs 1991-01-01 00:00:00
#################################################################
self.assertEqual(
pandas.read_csv(result_csv.data).to_dict(orient="records"),
[
{
"date_field": "2022-05-04 00:00:00.000",
"date_field": "2022-05-04 00:00:00",
"list_field": "Option 1",
"number_field": 3.1415926535,
"text_field": "Plain Text",
Expand Down
Loading