Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FileIO.append (for CSV, JSON and NDJSON) #44

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Implement FileIO.append (for CSV, JSON and NDJSON) #44

merged 4 commits into from
Nov 18, 2022

Conversation

bh2smith
Copy link
Collaborator

Closes #37

Adding support for "Append Functionality"!

@bh2smith bh2smith requested a review from a team November 18, 2022 12:16
@bh2smith bh2smith marked this pull request as ready for review November 18, 2022 12:16
gentrexha
gentrexha reviewed Nov 18, 2022
View reviewed changes
dune_client/file.py Outdated Show resolved Hide resolved
gentrexha
gentrexha approved these changes Nov 18, 2022
View reviewed changes
Copy link

@gentrexha gentrexha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on implementing this into the dune-client package!

LGTM!

@bh2smith bh2smith merged commit 2606417 into main Nov 18, 2022
@bh2smith bh2smith deleted the FileIO.append branch November 18, 2022 12:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gentrexha gentrexha gentrexha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Append to FileIO
2 participants
@bh2smith @gentrexha