-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Introducing CRUD Operations #59
Conversation
Hey @bh2smith answering here as conversation "has been locked and limited to collaborators" That's happening because it's trying to run this query which is deprecated for running on large cluster. Replace the sample query to any written on Trino and it'll be fine. |
Awesome thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some general comments and questions regarding implementations.
Dune recently added endpoints and documentation for their Queries Editing Support via the API. This PR introduces new functionality
create_query
get_query
update_query
archive_query
as well as
make_private
Unfortunately these operations require Premium membership, so I can not add tests yet.
*the the model
DuneQuery
should really make use of a real json serialization library (as well as any model implementing to/from dict), but this is a separate refactoring task.Note that the tests failing here are related to a previous PR. #58
cc @grkhr - I may have to revert those changes until this feature is working as expected. I tried with CURL and it was fine
cc @grkhr