Add workflow for building Docker image on commit to main #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
msf
reviewed
Jun 5, 2024
msf
reviewed
Jun 5, 2024
| @@ -0,0 +1,24 @@ | |||
| FROM golang:1.22-bookworm AS builder | |||
There was a problem hiding this comment.
I wonder if we should use 1.22-alpine
| COPY . /app/ | ||
| RUN make build | ||
|
|
||
| FROM debian:bookworm-slim |
There was a problem hiding this comment.
and use alpine:3.20 here
of course we then need to use apk instead of apt.. but maybe we just stick w/ debian
|
Regarding base Docker images and debian etc. I'm confused whether or not you're suggesting we change. I don't know enough about alpine/debian to know what would be best |
vegarsti
force-pushed
the
cd-workflow
branch
4 times, most recently
from
fe1a714
to
51a9ba0
Compare
vegarsti
changed the title
|
Ran successfully in the PR, changing it to run on merge to main |
vegarsti
commented
Jun 5, 2024
| name: "Build Docker image and push to Dockerhub" | ||
| name: "Lint and test" |
There was a problem hiding this comment.
I messed up the name in #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postponing pushing to a public registry, need to decide on the offical name.