Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esse PR busca implementar a escala cromática no
notas_musicais
.O que foi feito
ESCALAS
;test_deve_retornar_um_erro_dizendo_que_a_escala_não_existe
;Pontos de discussão
Literal
pra tentar garantir que as tonalidades enviadas pelo usuário seriam apenas as já implementadas, algo tipo:Mas acho que fugia do escopo do PR e talvez perdesse o sentido de alguns testes e validações como o
KeyError
, queria saber sua opinião sobre isso 🤔Extras
perdão por manchar o PR mas o TOC não deixou passar batido, se quiser posso tirar esse commit daqui e abrir outro PR