Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place dunst.service in session.slice #1397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Atemu
Copy link

@Atemu Atemu commented Nov 11, 2024

By default, systemd would place it in app.slice which doesn't make sense; that's where apps go, not daemons that are part of the desktop session.

session.slice makes a lot more sense for a daemon that's part of the desktop session.

Related: flatpak/xdg-desktop-portal-gtk#504

By default, systemd would place it in `app.slice` which doesn't make sense;
that's where apps go, not daemons that are part of the desktop session.

`session.slice` makes a lot more sense for a daemon that's part of the desktop
session.
Atemu added a commit to Atemu/nixos-config that referenced this pull request Nov 11, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.14%. Comparing base (43e3ac0) to head (6c4814e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1397   +/-   ##
=======================================
  Coverage   65.14%   65.14%           
=======================================
  Files          50       50           
  Lines        8651     8651           
  Branches     1022     1022           
=======================================
  Hits         5636     5636           
  Misses       3015     3015           
Flag Coverage Δ
unittests 65.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect
Copy link
Member

bynect commented Nov 11, 2024

Could you link some docs about the slice option? I found this https://www.freedesktop.org/software/systemd/man/latest/systemd.slice.html where it says

By default, service and scope units are placed in system.slice, virtual machines and containers registered with systemd-machined(8) are found in machine.slice, and user sessions handled by systemd-logind(8) in user.slice. See systemd.special(7) for more information

Maybe I am misinterpreting this but shouldn't the service be added by default to system.slice?

Atemu added a commit to Atemu/nixos-config that referenced this pull request Nov 12, 2024
@Atemu
Copy link
Author

Atemu commented Nov 12, 2024

The upstream docs are confusing on this but this is a user service, not a system service. I could not find it documented but user services appear to be placed in app.slice by default.

@bynect
Copy link
Member

bynect commented Nov 12, 2024

I found this https://www.freedesktop.org/software/systemd/man/latest/systemd.resource-control.html
which mentions user.slice and session.slice
The docs of systemd really are 💩 though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants