-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place dunst.service in session.slice #1397
base: master
Are you sure you want to change the base?
Conversation
By default, systemd would place it in `app.slice` which doesn't make sense; that's where apps go, not daemons that are part of the desktop session. `session.slice` makes a lot more sense for a daemon that's part of the desktop session.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1397 +/- ##
=======================================
Coverage 65.14% 65.14%
=======================================
Files 50 50
Lines 8651 8651
Branches 1022 1022
=======================================
Hits 5636 5636
Misses 3015 3015
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Could you link some docs about the slice option? I found this https://www.freedesktop.org/software/systemd/man/latest/systemd.slice.html where it says
Maybe I am misinterpreting this but shouldn't the service be added by default to system.slice? |
The upstream docs are confusing on this but this is a user service, not a system service. I could not find it documented but user services appear to be placed in app.slice by default. |
I found this https://www.freedesktop.org/software/systemd/man/latest/systemd.resource-control.html |
By default, systemd would place it in
app.slice
which doesn't make sense; that's where apps go, not daemons that are part of the desktop session.session.slice
makes a lot more sense for a daemon that's part of the desktop session.Related: flatpak/xdg-desktop-portal-gtk#504