Bugfix-2512 | rusk-wallet: Remove all panics in the codebase #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
reviewed
Nov 18, 2024
welf
force-pushed
the
bugfix-2512-rusk-wallet-remove-all-panics
branch
2 times, most recently
from
b15dff0
to
0511b0d
Compare
welf
force-pushed
the
bugfix-2512-rusk-wallet-remove-all-panics
branch
from
0511b0d
to
c475ee9
Compare
welf
force-pushed
the
bugfix-2512-rusk-wallet-remove-all-panics
branch
from
c475ee9
to
923789f
Compare
welf
added
fix:bug
Daksh14
reviewed
Nov 18, 2024
| // poison error and return the guard to the caller. | ||
| match state { | ||
| Ok(guard) => Arc::clone(&guard), | ||
| Err(poisoned) => Arc::clone(&poisoned.into_inner()), |
There was a problem hiding this comment.
This is a crate fn, if its called more than once we'll just deadlock anyways
The lock is also dropped once the function returns so im not sure if we need the match here. The function is also synchronous it won't be in a multithreaded environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From<f64> for Duskimplementation and replace it withTryFrom<f64> for DuskimplementationFrom<GraphQLError> for ErrorandFrom< InquireError> for ErrorMAX_PROFILESconstant and replace it withget_max_profilesfunction call to handle possible errors properlyUnrelated to panic handling
PasswordDisplayMode::HiddenwithPasswordDisplayMode::Maskedin password prompts to improve user experience when entering passwordsFuture improvements (for a separate PR)
inquiremenu. For non-critical errors, provide users with options to retry the failed operation or return to the previous menu, rather than always exiting with an error message.