Improve Prometheus regexp (#8039)

dust-tt · Oct 14, 2024 · 3541b94 · 3541b94
1 parent 749378f
commit 3541b94
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/alerting/temporal/src/qdrant/index.ts b/alerting/temporal/src/qdrant/index.ts
@@ -53,8 +53,15 @@ const NODE_AND_CLUSTER_REGEXP = /https:\/\/(node-\d+)-(.+)\:\d+/;
  */
 
 // Example: "grpc_responses_max_duration_seconds{endpoint="/qdrant.Points/Search"} 3.701747".
-const prometheusMetricsRegexp = /(\w+)(?:\{([^}]*)\})? (\d+(\.\d+)?)/;
-const supportedPrometheusLabels = ["endpoint", "le"] as const;
+// Support nested curly braces in labels.
+const prometheusMetricsRegexp =
+  /(\w+)(?:\{([^{}]*(?:\{[^{}]*\}[^{}]*)*)\})? (\d+(?:\.\d+)?)/;
+const supportedPrometheusLabels = [
+  "endpoint",
+  "le",
+  "method",
+  "status",
+] as const;
 type SupportedPrometheusLabels = (typeof supportedPrometheusLabels)[number];
 
 function isSupportedPrometheusLabel(
@@ -82,6 +89,7 @@ function extractMetricDetails(line: string) {
 
     return { name, labels, value };
   }
+
   return null;
 }