Skip to content

Commit

Permalink
[connectors] enh(Zendesk) Fix misleading comments (#8939)
Browse files Browse the repository at this point in the history
* ♻️

* remove a misleading comment

* 📝

* 📝
  • Loading branch information
aubin-tchoi authored and overmode committed Nov 27, 2024
1 parent 836e8be commit 74509fa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 2 additions & 1 deletion connectors/src/connectors/zendesk/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,7 @@ export class ZendeskConnectorManager extends BaseConnectorManager<null> {

/**
* Marks the connector as unpaused in db and restarts the workflows.
* Does not trigger full syncs, only restart the incremental and gc workflows.
*/
async unpause(): Promise<Result<undefined, Error>> {
const { connectorId } = this;
Expand All @@ -675,8 +676,8 @@ export class ZendeskConnectorManager extends BaseConnectorManager<null> {
logger.error({ connectorId }, "[Zendesk] Connector not found.");
return new Err(new Error("Connector not found"));
}
// reset the cursor here to trigger a full resync
await connector.markAsUnpaused();
// launch a gc and an incremental workflow (sync workflow without signals).
return this.resume();
}

Expand Down
6 changes: 1 addition & 5 deletions connectors/src/connectors/zendesk/lib/sync_ticket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,7 @@ ${comments
);
author = null;
}
return `
[${comment?.created_at}] ${
author ? `${author.name} (${author.email})` : "Unknown User"
}:
${comment.body}`;
return `[${comment?.created_at}] ${author ? `${author.name} (${author.email})` : "Unknown User"}:\n${comment.body}`;
})
.join("\n")}
`.trim();
Expand Down

0 comments on commit 74509fa

Please sign in to comment.