Enh/only forbid uppercase ascii (#3416)

* enh(tables): allow symbols and numbers in col names * delete table if rows upsert fails --------- Co-authored-by: Henry Fontanier <[email protected]>
dust-tt · Jan 24, 2024 · 803e85b · 803e85b
1 parent 98eeaab
commit 803e85b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/core/src/databases/database.rs b/core/src/databases/database.rs
@@ -231,11 +231,11 @@ impl Table {
                 None => Err(anyhow!("Row {} is not an object", row_index,))?,
             };
             match object.keys().find(|key| match key.chars().next() {
-                Some(c) => !c.is_ascii_lowercase(),
+                Some(c) => c.is_ascii_uppercase(),
                 None => false,
             }) {
                 Some(key) => Err(anyhow!(
-                    "Row {} has a key '{}' that is not lowercase",
+                    "Row {} has a key '{}' that contains uppercase characters",
                     row_index,
                     key
                 ))?,

diff --git a/front/pages/api/w/[wId]/data_sources/[name]/tables/csv.ts b/front/pages/api/w/[wId]/data_sources/[name]/tables/csv.ts
@@ -175,6 +175,25 @@ async function handler(
             "Failed to upsert rows."
           );
 
+          const delRes = await coreAPI.deleteTable({
+            projectId: dataSource.dustAPIProjectId,
+            dataSourceName: dataSource.name,
+            tableId,
+          });
+
+          if (delRes.isErr()) {
+            logger.error(
+              {
+                dataSourceName: dataSource.name,
+                workspaceId: owner.id,
+                tableId,
+                tableName: name,
+                error: delRes.error,
+              },
+              "Failed to delete table after failed upsert."
+            );
+          }
+
           return apiError(req, res, {
             status_code: 500,
             api_error: {