fix checks (#2726)

dust-tt · Nov 30, 2023 · 8c05d8e · 8c05d8e
1 parent 813785d
commit 8c05d8e
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 14 deletions.
diff --git a/connectors/src/connectors/slack/temporal/activities.ts b/connectors/src/connectors/slack/temporal/activities.ts
@@ -398,11 +398,13 @@ export async function syncNonThreaded(
     }
     hasMore = c.has_more;
   } while (hasMore);
+
   if (messages.length === 0) {
     // no non threaded messages, so we're done
     return;
   }
   messages.reverse();
+
   const text = await formatMessagesForUpsert(
     channelId,
     messages,
@@ -571,6 +573,11 @@ export async function syncThread(
   const botUserId = await getBotUserIdMemoized(slackClient);
   allMessages = allMessages.filter((m) => m.user !== botUserId);
 
+  if (allMessages.length === 0) {
+    // No threaded messages, so we're done.
+    return;
+  }
+
   const text = await formatMessagesForUpsert(
     channelId,
     allMessages,
@@ -603,6 +610,7 @@ export async function syncThread(
     messageTs: threadTs,
     documentId: documentId,
   });
+
   await upsertToDatasource({
     dataSourceConfig,
     documentId,

diff --git a/front/pages/api/v1/w/[wId]/data_sources/[name]/documents/[documentId]/index.ts b/front/pages/api/v1/w/[wId]/data_sources/[name]/documents/[documentId]/index.ts
@@ -199,13 +199,14 @@ async function handler(
         sourceUrl = standardizedSourceUrl;
       }
 
-      const section = bodyValidation.right.text
-        ? {
-            prefix: null,
-            content: bodyValidation.right.text,
-            sections: [],
-          }
-        : bodyValidation.right.section || null;
+      const section =
+        typeof bodyValidation.right.text === "string"
+          ? {
+              prefix: null,
+              content: bodyValidation.right.text,
+              sections: [],
+            }
+          : bodyValidation.right.section || null;
 
       if (!section) {
         return apiError(req, res, {

diff --git a/front/pages/api/w/[wId]/data_sources/[name]/documents/[documentId]/index.ts b/front/pages/api/w/[wId]/data_sources/[name]/documents/[documentId]/index.ts
@@ -106,13 +106,14 @@ async function handler(
         sourceUrl = standardizedSourceUrl;
       }
 
-      const section = bodyValidation.right.text
-        ? {
-            prefix: null,
-            content: bodyValidation.right.text,
-            sections: [],
-          }
-        : bodyValidation.right.section || null;
+      const section =
+        typeof bodyValidation.right.text === "string"
+          ? {
+              prefix: null,
+              content: bodyValidation.right.text,
+              sections: [],
+            }
+          : bodyValidation.right.section || null;
 
       if (!section) {
         return apiError(req, res, {