fix: remove where clause from notion GC (#6565)

Co-authored-by: Henry Fontanier <[email protected]>
dust-tt · Jul 29, 2024 · d1975cc · d1975cc
1 parent 1b0e776
commit d1975cc
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/connectors/src/connectors/notion/temporal/activities.ts b/connectors/src/connectors/notion/temporal/activities.ts
@@ -820,8 +820,7 @@ export async function garbageCollect({
   do {
     // Find the resources not seen in the GC run (using runTimestamp).
     resourcesToCheck = await findResourcesNotSeenInGarbageCollectionRun(
-      connector.id,
-      runTimestamp
+      connector.id
     );
 
     const NOTION_UNHEALTHY_ERROR_CODES = [
@@ -1074,8 +1073,7 @@ export async function deletePageOrDatabaseIfArchived({
 }
 
 async function findResourcesNotSeenInGarbageCollectionRun(
-  connectorId: ModelId,
-  runTimestamp: number
+  connectorId: ModelId
 ): Promise<
   Array<{
     lastSeenTs: Date;
@@ -1114,10 +1112,8 @@ async function findResourcesNotSeenInGarbageCollectionRun(
     await NotionPage.findAll({
       where: {
         connectorId,
-        lastSeenTs: {
-          [Op.lt]: new Date(runTimestamp),
-        },
       },
+      order: [["lastSeenTs", "ASC"]],
       attributes: ["lastSeenTs", "notionPageId", "skipReason"],
       limit: pageSize,
     })
@@ -1142,10 +1138,8 @@ async function findResourcesNotSeenInGarbageCollectionRun(
     await NotionDatabase.findAll({
       where: {
         connectorId,
-        lastSeenTs: {
-          [Op.lt]: new Date(runTimestamp),
-        },
       },
+      order: [["lastSeenTs", "ASC"]],
       attributes: ["lastSeenTs", "notionDatabaseId", "skipReason"],
       limit: pageSize,
     })