Skip to content

Commit

Permalink
make parentId mandatory in upsertDataSourceDocument and upsertDataSou…
Browse files Browse the repository at this point in the history
…rceFolder
  • Loading branch information
aubin-tchoi committed Dec 20, 2024
1 parent 7b3aeb2 commit d78e017
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions connectors/src/lib/data_sources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export type UpsertDataSourceDocumentParams = {
timestampMs?: number;
tags?: string[];
parents: string[];
parentId?: string | null;
parentId: string | null;
loggerArgs?: Record<string, string | number>;
upsertContext: UpsertContext;
title: string;
Expand Down Expand Up @@ -108,7 +108,7 @@ async function _upsertDataSourceDocument({
title,
mimeType,
async,
parentId = null,
parentId,
}: UpsertDataSourceDocumentParams) {
return tracer.trace(
`connectors`,
Expand Down Expand Up @@ -1229,15 +1229,15 @@ export async function _upsertDataSourceFolder({
folderId,
timestampMs,
parents,
parentId = parents[1] ?? null,
parentId,
title,
mimeType,
}: {
dataSourceConfig: DataSourceConfig;
folderId: string;
timestampMs?: number;
parents: string[];
parentId?: string | null;
parentId: string | null;
title: string;
mimeType: string;
}) {
Expand Down

0 comments on commit d78e017

Please sign in to comment.