Fix Quick guide double show up (#4190)

dust-tt · Mar 7, 2024 · d844e59 · d844e59
1 parent e7f890f
commit d844e59
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 29 deletions.
diff --git a/front/lib/swr.ts b/front/lib/swr.ts
@@ -244,7 +244,7 @@ export function useUser() {
 export function useUserMetadata(key: string) {
   const userMetadataFetcher: Fetcher<GetUserMetadataResponseBody> = fetcher;
 
-  const { data, error } = useSWR(
+  const { data, error, mutate } = useSWR(
     `/api/user/metadata/${encodeURIComponent(key)}`,
     userMetadataFetcher
   );
@@ -253,6 +253,7 @@ export function useUserMetadata(key: string) {
     metadata: data ? data.metadata : null,
     isMetadataLoading: !error && !data,
     isMetadataError: error,
+    mutateMetadata: mutate,
   };
 }
 

diff --git a/front/lib/user.ts b/front/lib/user.ts
@@ -24,35 +24,25 @@ export async function getUserMetadataFromClient(key: string) {
   }
 }
 
-/**
- * Client-side: sets the metadata for the current user. This function is best effort, and never
- * errors.
- * @param metadata MetadataType the metadata to set for the current user.
- */
-export function setUserMetadataFromClient(metadata: UserMetadataType) {
-  void (async () => {
-    try {
-      const res = await fetch(
-        `/api/user/metadata/${encodeURIComponent(metadata.key)}`,
-        {
-          method: "POST",
-          body: JSON.stringify({ value: metadata.value }),
-          headers: {
-            "Content-Type": "application/json",
-          },
-        }
-      );
+export async function setUserMetadataFromClient(metadata: UserMetadataType) {
+  const res = await fetch(
+    `/api/user/metadata/${encodeURIComponent(metadata.key)}`,
+    {
+      method: "POST",
+      body: JSON.stringify({ value: metadata.value }),
+      headers: {
+        "Content-Type": "application/json",
+      },
+    }
+  );
 
-      if (!res.ok) {
-        const err = await res.json();
-        console.error("setUserMetadata error", err);
-      }
+  if (!res.ok) {
+    const err = await res.json();
+    console.error("setUserMetadata error", err);
+    throw new Error(`Error setting user metadata: ${err.message}`);
+  }
 
-      // Finally mutate to kick SWR to revalidate.
-    } catch (err) {
-      console.error("setUserMetadata error", err);
-    }
-  })();
+  return;
 }
 
 export const guessFirstandLastNameFromFullName = (

diff --git a/front/pages/w/[wId]/assistant/new.tsx b/front/pages/w/[wId]/assistant/new.tsx
@@ -135,6 +135,7 @@ export default function AssistantNew({
     metadata: quickGuideSeen,
     isMetadataError: isQuickGuideSeenError,
     isMetadataLoading: isQuickGuideSeenLoading,
+    mutateMetadata: mutateQuickGuideSeen,
   } = useUserMetadata("quick_guide_seen");
   const [showQuickGuide, setShowQuickGuide] = useState<boolean>(false);
 
@@ -236,7 +237,11 @@ export default function AssistantNew({
   }, [user]);
 
   const { submit: persistQuickGuideSeen } = useSubmitFunction(async () => {
-    setUserMetadataFromClient({ key: "quick_guide_seen", value: "true" });
+    setUserMetadataFromClient({ key: "quick_guide_seen", value: "true" })
+      .then(() => {
+        return mutateQuickGuideSeen();
+      })
+      .catch(console.error);
     setShowQuickGuide(false);
   });