core database: small nits and refactoring #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spolu
commented
Nov 22, 2023
spolu
commented
- Comment dead code
- Move project to database instead of moved around in all function signatures
- Fix some comments
fontanierh
requested changes
Nov 22, 2023
core/src/stores/postgres.rs
Outdated
|
|
||
| Ok(DatabaseRow::new(row_created, Some(row_id), content)) | ||
| } | ||
| // async fn upsert_database_row( |
There was a problem hiding this comment.
Let's just get rid of this if we don't use it. I don't know that we ever will since we have a batch variant of this which can also work for a single row.
If we ever miss it, we'll find it in git history.
|
Thanks for the improvements ! |
fontanierh
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.