Gdrive: Ensure we have the valid rights before creating the connector #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopDaph
changed the title
spolu
reviewed
Nov 22, 2023
PopDaph
force-pushed
the
gdrive-sanity-check
branch
from
de15b38 to
2a9e2f1
Compare
spolu
approved these changes
Nov 22, 2023
|
Logic looks good to me but why use the .then() syntax given that we use await everywhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dust-tt/tasks/issues/247
We now display an error if we don't have both required permission (instead of allowing it and then breaking in the connector).
Error is ugly but that was already the case before, so won't fix in this PR 🙏🏻
