feat: add support for database blocks (front) #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopDaph
approved these changes
Nov 23, 2023
| <div className="flex flex-col flex-col gap-2 pt-4 xl:flex-row"> | ||
| <div className="flex flex-col xl:flex-row xl:space-x-2"> | ||
| <div className="mr-1 flex flex-initial text-sm font-medium leading-8 text-gray-700"> | ||
| Database: |
There was a problem hiding this comment.
NIT: Feel free to merge as is it's not a blocker > I wonder if we should edit the UI to make it clear that the first dropdown is a datasource and the second is the database inside the datasource.
Could be:
Datasource: [DropDown]
Database: [DropDown if datasource is selected and contains >0 database] or "No database in this datasource" or "Please select a datasource first".
There was a problem hiding this comment.
That's what it originally was, but @spolu preferred it like this
I personally don't really have an opinion here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has a
corefix as well (we were using the table ID instead of name when creating the SQLite DB).