Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ahuna] Test assistants in side modal from gallery (bis) #3016

Merged
merged 7 commits into from
Dec 26, 2023

Conversation

philipperolet
Copy link
Contributor

Follow-up of pr #3011
#3011 was reverted because tested assistants incorrectly showed in 'my assisants' list until the page was refreshed (or more precisely until swr cache was invalidated and list was grabbed again by server
This was due to an issue with next/swr caching: modifying an array returned by useSWR directly messes with the cache even across components with different urls
This is fixed in this follow-up PR

@philipperolet philipperolet merged commit 93b4644 into main Dec 26, 2023
2 checks passed
@philipperolet philipperolet deleted the test-assistant-modal branch December 26, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant