-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classify conversations instead of user_messages #3818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the deploy plan to release this PR. We should not rely on Sequelize to alter the table name.
} | ||
if (renderedConversation.length > 0) { | ||
if ( | ||
await ConversationClassification.findOne({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract the await from the if block?
Co-authored-by: Flavien David <[email protected]>
@flvndvd adjusted deploy plan. |
Description
After doing a first test of classifying 100 user messages, I realized that classifying conversations makes more sense.
A good amount of user messages seems to be just a follow up of a previous user messages, and without the whole list of user messages from the same conversation, it makes no sense to classify them.
We do not classify conversations with more than 30 messages, as they might talk about many different topics.
I also realized that I was missing a few categories.
Risk
Deploy Plan
DROP TABLE user_message_classifications