Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify conversations instead of user_messages #3818

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

lasryaric
Copy link
Contributor

@lasryaric lasryaric commented Feb 20, 2024

Description

After doing a first test of classifying 100 user messages, I realized that classifying conversations makes more sense.
A good amount of user messages seems to be just a follow up of a previous user messages, and without the whole list of user messages from the same conversation, it makes no sense to classify them.

We do not classify conversations with more than 30 messages, as they might talk about many different topics.

I also realized that I was missing a few categories.

Risk

Deploy Plan

  • deploy front
  • run on front DB : DROP TABLE user_message_classifications
  • npm run initdb (on front)

@lasryaric lasryaric requested a review from flvndvd February 20, 2024 12:50
Copy link

github-actions bot commented Feb 20, 2024

Warnings
⚠️

Files in front/lib/models/ or connectors/src/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from the -edge infrastructure.

Generated by 🚫 dangerJS against 4ae390d

Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the deploy plan to release this PR. We should not rely on Sequelize to alter the table name.

front/admin/tools/message_classification.ts Outdated Show resolved Hide resolved
}
if (renderedConversation.length > 0) {
if (
await ConversationClassification.findOne({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract the await from the if block?

@lasryaric
Copy link
Contributor Author

Please update the deploy plan to release this PR. We should not rely on Sequelize to alter the table name.

@flvndvd adjusted deploy plan.
I tested and can confirm that the app is not going to crash if we make no call to the user_message_classifications table.

@lasryaric lasryaric added the migration-ack 📁 Label to acknowledge that a migration is required. label Feb 20, 2024
@lasryaric lasryaric merged commit bf276b3 into main Feb 20, 2024
6 checks passed
@lasryaric lasryaric deleted the aric-classify_conversation branch February 20, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants