Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flav/fix empty structured table #3819

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

flvndvd
Copy link
Contributor

@flvndvd flvndvd commented Feb 20, 2024

Description

This PR fixes https://github.com/dust-tt/tasks/issues/446.

It also:

  • adds a tag on all the Google Drive spreadsheet logs
  • don't upsert the table if less than 2 rows (headers + at least one line of data)

Risk

Deploy Plan

@flvndvd flvndvd marked this pull request as ready for review February 20, 2024 12:59
@flvndvd flvndvd requested a review from fontanierh February 20, 2024 13:04
@flvndvd flvndvd self-assigned this Feb 20, 2024
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -108,7 +108,7 @@ function getSanitizedHeaders(rawHeaders: string[], loggerArgs: object) {
} else {
logger.info(
loggerArgs,
"Duplicated headers detected; suffixes added for uniqueness."
"[Spreadsheet] Duplicated headers detected; suffixes added for uniqueness."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict incoming :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@flvndvd flvndvd merged commit 86d970c into main Feb 20, 2024
5 checks passed
@flvndvd flvndvd deleted the flav/fix-empty-structured-table branch February 20, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants