Connector: implement retrieve content nodes for Gdrive #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopDaph
force-pushed
the
retrieve-content-node-gdrive
branch
from
477a262 to
252e344
Compare
lasryaric
reviewed
Mar 4, 2024
| title: f.name || "", | ||
| dustDocumentId: getGoogleDriveEntityDocumentId(f), | ||
| lastUpdatedAt: f.lastUpsertedTs?.getTime() || null, | ||
| sourceUrl: null, |
There was a problem hiding this comment.
Because it's empty when we retrieve the read permissions and out of consistency I kept the exact same behavior!
There was a problem hiding this comment.
Actually I think it's better to have it and the consistency should be with all connector on this screen instead of per connector. I added something, looks like it's working but let me know if you think it's better to fetch the API to retrieve the url from the API
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're implementing a "retrieve content nodes" for each connector.
It is meant to replace "retrieve resource titles".
More context here: #4044
This is the PR for Gdrive.
Risk
Low as not used yet.
Deploy Plan
Nothing special.