-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anthropic: Chat completion & Claude 3 (Opus) #4180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
core/src/providers/anthropic.rs
Outdated
None, | ||
stop_tokens.as_ref(), | ||
) | ||
println!("body: {}", body); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
core/src/providers/anthropic.rs
Outdated
}; | ||
|
||
if system.is_some() { | ||
println!("system: {:?}", system); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to keep this log ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah no good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀 🚀
Description
Fixes: #4148
This PR does not remove claude-2 or claude-instant. It does rename @claude into @claude-2 but that's just a pure front-end renaming (sId are preserved, renaming impacts all past and future conversations, no migration)
Risk
N/A
Deploy Plan
core
(this will break claude 2 (not 2.1 so ~no-one) chat access)front