Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anthropic: Chat completion & Claude 3 (Opus) #4180

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Mar 6, 2024

Description

Fixes: #4148

  • core: Anthropic chat completion + streaming
  • core: Fix mistral context size computation
  • front: Add opus and sonnet latest model (Dust apps) (new chat/non chat distinction)
  • front: Add claude-3 (both as global agent and available model to build assistants)
  • front: Add claude-3-sonnet (global agent only)
  • front: Fixes a few bugs around agents seen here and there.

This PR does not remove claude-2 or claude-instant. It does rename @claude into @claude-2 but that's just a pure front-end renaming (sId are preserved, renaming impacts all past and future conversations, no migration)

Risk

N/A

Deploy Plan

  • deploy core (this will break claude 2 (not 2.1 so ~no-one) chat access)
  • deploy front

@spolu spolu changed the title [WIP] Anthropic: Chat completion Anthropic: Chat completion & Claude 3 (Opus) Mar 7, 2024
@spolu spolu requested review from fontanierh and flvndvd and removed request for fontanierh March 7, 2024 14:59
@spolu spolu requested a review from fontanierh March 7, 2024 15:06
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

None,
stop_tokens.as_ref(),
)
println!("body: {}", body);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit cleanup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

};

if system.is_some() {
println!("system: {:?}", system);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to keep this log ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no good catch

Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀 🚀

@spolu spolu merged commit f2cff65 into main Mar 7, 2024
5 checks passed
@spolu spolu deleted the spolu-anthropic_messages branch March 7, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Claude 3
3 participants