[Front Search] Better, stabler, cooler, stronger sort order for results #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement over the previous version, cf test case WIP: still wondering where to put the tests
philipperolet
force-pushed
the
better-fuzzy-search
branch
from
23a4e29 to
e09a1df
Compare
fontanierh
approved these changes
Mar 8, 2024
| return i === a.length ? j : -1; | ||
| } | ||
|
|
||
| function subFilterFirstIndex(a: string, b: string) { |
There was a problem hiding this comment.
I don't understand what this does. Could you add a comment ?
There was a problem hiding this comment.
👍 made one as clear as I could, hope it's fine
flvndvd
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement over the previous version, cf test cases
WIP: need to move the tests to a good place. I'm thinking
Before
After
Risk & deploy plan
Assistant autocomplete in blast radius
=> Test on front edge