Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workspace with SSO enforced #4227

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Support workspace with SSO enforced #4227

merged 3 commits into from
Mar 8, 2024

Conversation

flvndvd
Copy link
Contributor

@flvndvd flvndvd commented Mar 8, 2024

Description

This PR introduces a new feature that allows workspace administrators to enforce Single Sign-On (SSO) for all users within their workspace. By enabling the SSO enforcement option, admins can ensure that every user logs in exclusively through the designated SSO provider.

This check needs to happen at the server side rendering time to ensure that the check applies anytime an admin update the settings.

This does not expose this setting yet in the UI. We first need to be able to merge accounts before doing so.

image

Risk

Deploy Plan

This requires to run a migration to add the ssoEnforced field on the Workspace model.

Copy link

github-actions bot commented Mar 8, 2024

Warnings
⚠️

Files in front/lib/models/ or connectors/src/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from the -edge infrastructure.

Generated by 🚫 dangerJS against 4c1f66c

@flvndvd flvndvd marked this pull request as ready for review March 8, 2024 15:40
@flvndvd flvndvd added the migration-ack 📁 Label to acknowledge that a migration is required. label Mar 8, 2024
@flvndvd flvndvd merged commit c19ca2a into main Mar 8, 2024
9 checks passed
@flvndvd flvndvd deleted the flav/enforce-sso-control branch March 8, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants