Clamp notification content #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duncid
approved these changes
Apr 3, 2024
|
LGTM |
flvndvd
added a commit
that referenced
this pull request
May 26, 2024
* Clamp notification content * Bump to max 320px * ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves https://github.com/dust-tt/tasks/issues/594.
This PR clamps notification's content since we don't always control what's being displayed there. This is a dirty hack since this text isn't easy to split (no whitespaces). We should instead improve our error handling to avoid logging those types of errors.
Risk
Deploy Plan