Enhance external image hosting in agent configuration #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolu
approved these changes
Apr 4, 2024
| @@ -0,0 +1,52 @@ | |||
| import type { Bucket } from "@google-cloud/storage"; | |||
There was a problem hiding this comment.
gcs rather than dfs in name no?
There was a problem hiding this comment.
I stick with DFS for this file/class but all other occurrences will go with GCS.
I was planning to do it in a follow up PR, but let me bake this into this PR. |
|
Up to you 👍 |
spolu
approved these changes
Apr 4, 2024
flvndvd
added a commit
that referenced
this pull request
May 26, 2024
* Strengthen external image hosting in agent configuration * ✂️ * ✂️ * ✂️ * Apply new DFS logic to content fragment + refactor * Accept static hosted Dust Avatars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #4556.
This PR addresses a security issue by improving the way we handle image uploads. It ensures that uploaded files have an image* mimeType, are less than 3MB in size, and restricts the accepted file types in the file picker.
In the agent configuration creation, it verifies that the file is self-hosted on our GCS and has the proper mime type, or it will yield an error.
To make this solution more resilient in the future, this PR starts centralizing the DFS (Distributed File System) logic in one single place.
It also applies some refactoring to the existing logic of content fragment, to use the newly introduced
DFSclass.Risk
Worst case it breaks avatar upload on agent configuration or the content fragment (uploading file, downloading file, ...), but it has been well tested locally.
Deploy Plan