Fix: assistant picker broken if some assistant names > 20 chars #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipperolet
force-pushed
the
fix-picker
branch
from
f6a7647 to
103bb56
Compare
flvndvd
reviewed
Apr 4, 2024
| * `maxStringLength`. | ||
| * @param str The string to truncate. | ||
| */ | ||
| export function ellipsis(str: string, maxStringLength: number) { |
There was a problem hiding this comment.
Why not using CSS classes for this?
There was a problem hiding this comment.
We could but IMHO the downsides are:
- not usable elswhere than inside tags in .tsx;
- less convenient, harder to setup ( text-ellipsis cannot be used alone, we need to think about other concerns such as do I want overflow-hidden, wrap/no wrap, do I need to set a max-width --> asking those questions is sometimes relevant, sometimes not and we lose time and complexify css just for the sake of the ellipsis)
There was a problem hiding this comment.
less convenient, harder to setup ( text-ellipsis cannot be used alone, we need to think about other concerns such as do I want overflow-hidden, wrap/no wrap, do I need to set a max-width --> asking those questions is sometimes relevant, sometimes not and we lose time and complexify css just for the sake of the ellipsis)
To me, it can be configure as easily as what's being done here and offer a nicer UX. Here 20 characters might work on a laptop but not on mobile. Leveraging CSS covers everything 😉
flvndvd
approved these changes
Apr 4, 2024
| visual={c.pictureUrl} | ||
| hasAction={false} | ||
| onClick={() => { | ||
| onItemClick(c); | ||
| setSearchText(""); | ||
| }} | ||
| className="truncate" |
flvndvd
pushed a commit
that referenced
this pull request
May 26, 2024
* Fix: assistant picker broken if some assistant names > 20 chars * review * clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title & screenshot
Note: also switches spinner to spinner2 in instructions, which fixes https://github.com/dust-tt/tasks/issues/612
Risk
Deploy Plan