Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating PricePlans #4774

Merged
merged 3 commits into from
Apr 19, 2024
Merged

updating PricePlans #4774

merged 3 commits into from
Apr 19, 2024

Conversation

Duncid
Copy link
Contributor

@Duncid Duncid commented Apr 19, 2024

Description

Updating PricePlans for website

@Duncid Duncid requested a review from flvndvd April 19, 2024 08:13
Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment.

<div className="s-flex s-h-full s-flex-col s-justify-end">{children}</div>
</div>
<>
{position === "bottom" ? <div className="s-h-full s-w-full" /> : null}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty div, seems weird, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here for spacing, it's ok!

@Duncid Duncid merged commit dc1e183 into main Apr 19, 2024
4 checks passed
@Duncid Duncid deleted the SparklePricePlans branch April 19, 2024 09:33
flvndvd pushed a commit that referenced this pull request May 26, 2024
* updating PricePlans

* Fix import

* Dark support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants