[sparkle] internal: use new sparkle packaging - take 2 #6091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdraier
force-pushed
the
sparkle-usage-again
branch
from
d102d1d to
057973f
Compare
flvndvd
approved these changes
Sep 3, 2024
| @@ -1,4 +1,4 @@ | |||
| import type { CitationType } from "@dust-tt/sparkle/dist/cjs/components/Citation"; | |||
| import type { CitationType } from "@dust-tt/sparkle/dist/esm/components/Citation"; | |||
There was a problem hiding this comment.
Seen IRL, we will find a way to improve the type situation afterward.
There was a problem hiding this comment.
We'll add a proper exports for types, removing all direct imports for now
tdraier
added a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for new sparkle packaging
Uses @0.2.187-esm , need to be updated once #6090 is validated/published , before merging
Risk
Rollback plan :
Deploy Plan
deploy front